Skip to content

refactor(cmd): extract contextual-help catalog; fix misleading benchmark #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patel230 merged 2 commits into from
Sep 15, 2026
Merged

refactor(cmd): extract contextual-help catalog; fix misleading benchmark #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f52f53
refactor(cmd): extract contextual-help catalog; fix misleading benchmark
Patel230 Sep 15, 2026
86ff279
test(cmd): restore input border and chrome mode in theme test cleanup
Patel230 Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/chat_model_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ func restoreThemeGlobals(t *testing.T) {
savedCost, savedBranch, savedToken, savedCwd := costViolet, branchYellow, tokenSage, cwdBlue
savedPrimary, savedMuted, savedPlaceholder, savedDisabled := textPrimary, textMuted, textPlaceholder, textDisabled
savedBorderDim, savedBgCode := borderDim, bgCode
savedInputBorder := inputBorderStyle
savedMinimalChrome := minimalChrome
hasDark := lipgloss.HasDarkBackground(os.Stdin, os.Stdout)
t.Cleanup(func() {
rhoColor, successTeal, warnAmber, errorCoral, infoSky = savedRho, savedSuccess, savedWarn, savedErr, savedInfo
Expand All @@ -93,6 +95,10 @@ func restoreThemeGlobals(t *testing.T) {
costViolet, branchYellow, tokenSage, cwdBlue = savedCost, savedBranch, savedToken, savedCwd
textPrimary, textMuted, textPlaceholder, textDisabled = savedPrimary, savedMuted, savedPlaceholder, savedDisabled
borderDim, bgCode = savedBorderDim, savedBgCode
// ApplyTheme also rewrites the input border and chrome mode; restore
// them so a palette swap cannot leak into layout tests.
inputBorderStyle = savedInputBorder
minimalChrome = savedMinimalChrome
// HasDarkBackground is now a function (no args), SetHasDarkBackground removed in v2
_ = hasDark
})
Expand Down
Loading
Loading