refactor(cmd): extract contextual-help catalog; fix misleading benchmark - #313
Merged
Merged
Conversation
- registerAllEntries (447 lines) is now a 7-line loop over a package-level help-entry catalog. - Fix BenchmarkIsSensitivePath: literal /home/... paths hit macOS autofs and measured ~22ms/op; realistic paths show ~130us/op.
ApplyTheme rewrites inputBorderStyle and minimalChrome; restoreThemeGlobals only restored colors, so a tau palette swap leaked into layout tests and made TestView_LineCountMatchesHeight order-dependent under -shuffle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registerAllEntries(447 lines) is now a 7-line loop over a package-levelbuiltinHelpEntriescatalog.BenchmarkIsSensitivePathused literal/home/...paths, which on macOS hit the autofs automounter and reported ~22ms/op. Realistic home/temp paths show ~130µs/op, so there is no real perf bug.Verified:
go vet,golangci-lint(0 issues),go test ./cmd/, gofumpt clean.