feat: complete pages and move data to json - #3
Open
rammmaa wants to merge 19 commits into
Open
Conversation
✅ Deploy Preview for molgo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
미완성이던 페이지를 완성하고, Google Sheets 대신 레포 안 JSON을 데이터 원본으로 바꿨습니다.
feature/theme-toggle브랜치에 있던 재설계(PageHeader, 연도별 수상 표, 활동 페이지, 주소 있는 푸터, 라이트·다크 테마)를 main 규약(shadcn, lucide, next/image, 디자인 토큰)에 맞춰 이식했습니다.스펙:
docs/superpowers/specs/2026-09-05-complete-pages-design.md계획:
docs/superpowers/plans/2026-09-05-complete-pages.md결정 사항
data/*.json이 원본. zod 스키마(lib/schema.ts)로 빌드 시 검증하고, 명단 핸들과 수상자 핸들이members.json에 있는지 참조 무결성까지 검사합니다. 잘못된 데이터는 빌드가 실패해 배포되지 않습니다.pnpm import:sheets와 검증용pnpm check:data를 두었습니다. 기존 시트 CSV는 빈 행 23,960개를 포함해 355KB였고 60초마다 다시 받고 있었습니다.JOIN_FORM_URL(구글폼)입니다.페이지별 변경
sessions.json이 채워지면 정기 세션 기록 표가 나타납니다.next-themes, 기본 다크), 헤더 토글, 주소와 이메일이 있는 푸터, 페이지별<title>, 404 페이지,sitemap.xml,robots.txt,.env.example, 한국어 README.확인
pnpm lint,pnpm typecheck,pnpm test(26개),pnpm check:data,pnpm build통과.후속 작업
data/awards.json에서 "교내 1위" 같은 문구로 다듬어 주세요.main으로 연결해야 새 사이트가 배포됩니다.NEXT_PUBLIC_SITE_URL,JOIN_FORM_URL,DONATION_ACCOUNT,DONATION_CONTACT_URL.