Support inclusion of build-time and runtime dependencies - #99
Draft
pont-us wants to merge 5 commits into
Draft
Conversation
Initial implementation of #98. Basic functionality tested but still needs more testing, evaluation, and documentation.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 97.83% 96.73% -1.11%
==========================================
Files 6 6
Lines 647 765 +118
Branches 77 109 +32
==========================================
+ Hits 633 740 +107
- Misses 9 18 +9
- Partials 5 7 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Add a code snippet to make sure that the notebook's parent directory is on the Python path during parameter extraction. - Make sure that files copied into container are owned by mambauser. - Don't strip root directory when copying includes into container image.
Emphasize that the parameters cell should be the first code cell whenever possible.
Recent additions to the parameter-extraction code try to add the notebook path's parent directory to the Python path, which naturally fails if the notebook path is a URL rather than a local path. This commit ensures that a parent "directory" really is a directory before trying to put it on the Python path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98