Skip to content

[viostor] Fixup VirtIoAdapterControl() #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
benyamin-codez wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[viostor] Fixup VirtIoAdapterControl() #1516

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd240c7
[viostor] Fixup VirtIoAdapterControl() - Cleanup variables
benyamin-codez Feb 7, 2026
d6e449f
[viostor] Fixup VirtIoAdapterControl() - Tracing
benyamin-codez Feb 7, 2026
70ed46d
[viostor] Fixup VirtIoAdapterControl() - SupportedControlTypes
benyamin-codez Feb 7, 2026
14e7e7a
[viostor] Fixup VirtIoAdapterControl() - Add ScsiAdapterSurpriseRemoval
benyamin-codez Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions viostor/virtio_stor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,28 +1282,29 @@ VirtIoResetBus(IN PVOID DeviceExtension, IN ULONG PathId)
SCSI_ADAPTER_CONTROL_STATUS
VirtIoAdapterControl(IN PVOID DeviceExtension, IN SCSI_ADAPTER_CONTROL_TYPE ControlType, IN PVOID Parameters)
{
PADAPTER_EXTENSION adaptExt = (PADAPTER_EXTENSION)DeviceExtension;
PSCSI_SUPPORTED_CONTROL_TYPE_LIST ControlTypeList;
ULONG AdjustedMaxControlType;
ULONG Index;
PADAPTER_EXTENSION adaptExt;
ULONG list_idx;
SCSI_ADAPTER_CONTROL_STATUS status = ScsiAdapterControlUnsuccessful;
BOOLEAN SupportedControlTypes[5] = {TRUE, TRUE, TRUE, FALSE, FALSE};
BOOLEAN SupportedControlTypes[ScsiAdapterControlMax] = {FALSE};

adaptExt = (PADAPTER_EXTENSION)DeviceExtension;

RhelDbgPrint(TRACE_LEVEL_VERBOSE, " ControlType %d\n", ControlType);
SupportedControlTypes[ScsiQuerySupportedControlTypes] = TRUE;
SupportedControlTypes[ScsiStopAdapter] = TRUE;
SupportedControlTypes[ScsiRestartAdapter] = TRUE;
SupportedControlTypes[ScsiAdapterSurpriseRemoval] = TRUE;
Comment thread
benyamin-codez marked this conversation as resolved.

switch (ControlType)
{

case ScsiQuerySupportedControlTypes:
{
RhelDbgPrint(TRACE_LEVEL_VERBOSE, " ScsiQuerySupportedControlTypes\n");
ControlTypeList = (PSCSI_SUPPORTED_CONTROL_TYPE_LIST)Parameters;
AdjustedMaxControlType = (ControlTypeList->MaxControlType < 5) ? ControlTypeList->MaxControlType : 5;
for (Index = 0; Index < AdjustedMaxControlType; Index++)
AdjustedMaxControlType = (ControlTypeList->MaxControlType < ScsiAdapterControlMax) ? ControlTypeList->MaxControlType
: ScsiAdapterControlMax;
Comment thread
benyamin-codez marked this conversation as resolved.
for (list_idx = 0; list_idx < AdjustedMaxControlType; list_idx++)
{
ControlTypeList->SupportedTypeList[Index] = SupportedControlTypes[Index];
ControlTypeList->SupportedTypeList[list_idx] = SupportedControlTypes[list_idx];
}
status = ScsiAdapterControlSuccess;
break;
Expand Down Expand Up @@ -1340,7 +1341,15 @@ VirtIoAdapterControl(IN PVOID DeviceExtension, IN SCSI_ADAPTER_CONTROL_TYPE Cont
status = ScsiAdapterControlSuccess;
break;
}
case ScsiAdapterSurpriseRemoval:
{
RhelDbgPrint(TRACE_LEVEL_FATAL, " ScsiAdapterSurpriseRemoval\n");
adaptExt->removed = TRUE;
status = ScsiAdapterControlSuccess;
break;
}
default:
RhelDbgPrint(TRACE_LEVEL_ERROR, " Unsupported ControlType %d\n", ControlType);
break;
}

Expand Down