fix: Select lineDensity series and groupby columns into the base query - #1198
Draft
domoritz wants to merge 1 commit into
Draft
fix: Select lineDensity series and groupby columns into the base query#1198domoritz wants to merge 1 commit into
domoritz wants to merge 1 commit into
Conversation
Fixes #1193. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1193. Part of the audit tracked in #1170.
What changed
lineDensitynow selects itszandgroupbycolumns into the base query when they are not already among its select aliases, so thepairsCTE can partition by them. Callers that pre-select aliased channels (vgplot'sDenseLineMark) are unchanged: the added columns only fill in what is missing. Binder-backed tests coverz,groupby, and the pre-selected case.🤖 Generated with Claude Code
https://claude.ai/code/session_01DEmcoxyFx2BRM5BbmJGFsa