refactor(sql): Collapse toDuckDBValue into literalToSQL - #1180
Draft
domoritz wants to merge 1 commit into
Draft
Conversation
This was referenced Sep 3, 2026
Fixes #1179 (finding S-02). After #1174 the two serializers agree case-for-case, so the load path now goes through the one literal serializer and one escaping path. Booleans in read options are emitted as TRUE/FALSE, which DuckDB treats identically. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DEmcoxyFx2BRM5BbmJGFsa
domoritz
force-pushed
the
sql-simplify/S-02
branch
from
September 3, 2026 02:46
ad01ba0 to
738b474
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1179. Part of the audit tracked in #1170. Stacked on #1176 — retarget to
mainonce that merges; the diff here is only this change.What changed
toDuckDBValueinload.tsis deleted andparameters()callsliteralToSQLdirectly, so read options go through the same serializer and escaping path as every other literal. Booleans in read options now emitTRUE/FALSEinstead oftrue/false(identical to DuckDB) and non-finite numbers emitNULLinstead ofInfinity(which never bound). Test expectations and the generated-SQL examples indocs/sql/index.mdanddocs/api/sql/data-loading.mdare updated for the casing.🤖 Generated with Claude Code
https://claude.ai/code/session_01DEmcoxyFx2BRM5BbmJGFsa