Skip to content

ci(publish): skip publish for packages not built into the images - #4821

Merged
myftija merged 1 commit into
mainfrom
tri-publish-ignore-cli
Aug 28, 2026
Merged

ci(publish): skip publish for packages not built into the images#4821
myftija merged 1 commit into
mainfrom
tri-publish-ignore-cli

Conversation

@myftija

@myftija myftija commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

publish.yml builds the webapp and worker/supervisor images (and dispatches the enterprise-image build off the webapp). It currently triggers on all of packages/** and internal-packages/**, so a change confined to a package that never lands in those images still publishes new images.

This adds paths negations for packages that are not built into either image:

  • packages (npm-only libraries / CLI): cli-v3, build, python, react-hooks, rsc, schema-to-json
  • internal-packages (test/tooling only): testcontainers, sdk-compat-tests, observability-map

publish.yml builds the webapp and worker/supervisor images. Ignore changes
confined to packages that never land in those images so a docker publish (and
the downstream enterprise-image dispatch) isn't triggered for a no-op:

- packages: cli-v3, build, python, react-hooks, rsc, schema-to-json (npm-only)
- internal-packages: testcontainers, sdk-compat-tests, observability-map (test/tooling)

Verified by imports, not the dependency closure: the webapp imports
@internal/clickhouse and @internal/replication despite not declaring them, so
those (and everything else in the image) keep triggering publish.
@changeset-bot

changeset-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4cfce96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@myftija
myftija enabled auto-merge (squash) August 28, 2026 15:36
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 527552ab-155e-4dab-bf86-98409b57d265

📥 Commits

Reviewing files that changed from the base of the PR and between f42c820 and 4cfce96.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: code-quality / code-quality
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
.github/workflows/publish.yml (1)

36-47: LGTM!


Walkthrough

The publish workflow now excludes nine CLI, library, test, and tooling package paths from its push trigger. Changes in these paths no longer start the workflow.

Merge Risk: ⚪ Minimal · up to 4cfce

This change prevents unnecessary image publishing when unrelated packages change and introduces no actionable merge-blocking risk beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description clearly explains the workflow change and lists the excluded packages, but it omits the required issue reference, checklist, testing details, changelog, and screenshots sections. Add the required template sections. Include the issue reference, completed checklist items, testing steps and results, a short changelog entry, and screenshots or an explicit statement that screenshots are not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: preventing image publishing for packages not included in the images.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tri-publish-ignore-cli

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@myftija
myftija merged commit cca41a4 into main Aug 28, 2026
31 checks passed
@myftija
myftija deleted the tri-publish-ignore-cli branch August 28, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants