ci(publish): skip publish for packages not built into the images - #4821
Conversation
publish.yml builds the webapp and worker/supervisor images. Ignore changes confined to packages that never land in those images so a docker publish (and the downstream enterprise-image dispatch) isn't triggered for a no-op: - packages: cli-v3, build, python, react-hooks, rsc, schema-to-json (npm-only) - internal-packages: testcontainers, sdk-compat-tests, observability-map (test/tooling) Verified by imports, not the dependency closure: the webapp imports @internal/clickhouse and @internal/replication despite not declaring them, so those (and everything else in the image) keep triggering publish.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🔇 Additional comments (1)
WalkthroughThe publish workflow now excludes nine CLI, library, test, and tooling package paths from its Merge Risk: ⚪ Minimal · up to This change prevents unnecessary image publishing when unrelated packages change and introduces no actionable merge-blocking risk beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
publish.ymlbuilds the webapp and worker/supervisor images (and dispatches the enterprise-image build off the webapp). It currently triggers on all ofpackages/**andinternal-packages/**, so a change confined to a package that never lands in those images still publishes new images.This adds
pathsnegations for packages that are not built into either image:cli-v3,build,python,react-hooks,rsc,schema-to-jsontestcontainers,sdk-compat-tests,observability-map