Skip to content

fix(cli): preserve empty failure diagnostics - #554

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/cli-command-failure-analysis-feb9
Draft

fix(cli): preserve empty failure diagnostics#554
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/cli-command-failure-analysis-feb9

Conversation

@cursor

@cursor cursor Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • fall back to an exception's class name when its sanitized CLI error message is empty
  • keep failure telemetry categorical and privacy-safe instead of allowing the error property to disappear
  • cover generic and Cyclopts exceptions with empty diagnostics

Tests

  • TOGETHER_TELEMETRY_DISABLED=1 .venv/bin/pytest tests/unit/test_cli_telemetry.py tests/cli/test_command_telemetry.py -n 0 (48 passed)
  • .venv/bin/ruff check src/together/lib/cli/_track_cli.py tests/unit/test_cli_telemetry.py
  • .venv/bin/ruff format --check src/together/lib/cli/_track_cli.py tests/unit/test_cli_telemetry.py
  • uv run pyright src/together/lib/cli/_track_cli.py tests/unit/test_cli_telemetry.py
Open in Web View Automation 

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Caution

⚠️ 2 file(s) not yet AI-analyzed — re-analysis in progress, this comment will update

⚠️ No findings collected before the scan deadline.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.3-Flash) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant