Skip to content

[SDK Sentinel] Stabilize cancelled deployment version updates #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdk-sentinel-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −9
Open

[SDK Sentinel] Stabilize cancelled deployment version updates #1792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions tests/worker/test_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
Runtime,
TelemetryConfig,
)
from temporalio.service import RPCError
from temporalio.service import RPCError, RPCStatusCode
from temporalio.testing import WorkflowEnvironment
from temporalio.worker import (
ActivitySlotInfo,
Expand Down Expand Up @@ -1298,14 +1298,38 @@ async def mk_call() -> DescribeWorkerDeploymentResponse:
async def set_current_deployment_version(
client: Client, conflict_token: bytes, version: WorkerDeploymentVersion
) -> SetWorkerDeploymentCurrentVersionResponse:
return await client.workflow_service.set_worker_deployment_current_version(
SetWorkerDeploymentCurrentVersionRequest(
namespace=client.namespace,
deployment_name=version.deployment_name,
version=version.to_canonical_string(),
conflict_token=conflict_token,
)
)
async def mk_call() -> SetWorkerDeploymentCurrentVersionResponse:
nonlocal conflict_token
try:
return await client.workflow_service.set_worker_deployment_current_version(
SetWorkerDeploymentCurrentVersionRequest(
namespace=client.namespace,
deployment_name=version.deployment_name,
version=version.to_canonical_string(),
conflict_token=conflict_token,
)
)
except RPCError as err:
if err.status != RPCStatusCode.CANCELLED:
raise
describe_resp = await client.workflow_service.describe_worker_deployment(
DescribeWorkerDeploymentRequest(
namespace=client.namespace,
deployment_name=version.deployment_name,
)
)
current_version = describe_resp.worker_deployment_info.routing_config.current_deployment_version
if (
current_version.deployment_name == version.deployment_name
and current_version.build_id == version.build_id
):
return SetWorkerDeploymentCurrentVersionResponse(
conflict_token=describe_resp.conflict_token
)
conflict_token = describe_resp.conflict_token
assert False

return await assert_eventually(mk_call, retry_on_rpc_cancelled=False)


async def set_ramping_version(
Expand Down