Build only on push and tag - #28
Closed
cyberb wants to merge 1 commit into
Closed
Conversation
The pipeline had no trigger block, so Drone fell back to its default of building every event. Opening a pull request therefore produced a second, identical build alongside the one for the branch push — see builds 103 and 104, both on b5dd403. Restricting to push covers branches and master. Tag has to stay in the list because the github-release step is gated on `when: event: tag`, and a trigger without it would stop tag builds entirely and silently end APK publishing. This is why the bitwarden pipeline's `event: ['push']` cannot be copied here verbatim.
Member
Author
|
Folded into #27 so the API 36 upgrade and the trigger fix land as one commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.drone.jsonnethad no top-leveltriggerblock, so Drone fell back to its default of building on every event. Opening a PR therefore fires a second, identical build next to the branch-push one:Same commit, twice. This adds:
pushcovers branches and master, so PRs still get built — once, via their branch push.taghas to stay in the list. Thepublish to githubstep is gated onwhen: { event: [ "tag" ] }; a trigger ofevent: ['push']alone would stop tag builds firing at all and silently end APK publishing to GitHub releases. That's whybitwarden's push-only trigger can't be copied here verbatim — it has no tag-gated step.Verified with
drone jsonnet+drone lint; the generated YAML keeps the release step'swhen: event: [tag]intact alongside the new trigger.