Updates to replace pointers with iterators for BAM and SAM inputs - #121
Merged
Conversation
… get around issues related to using raw pointers and pointer arithmetic
…parently one step before using from_chars recently added to falco namespace in falco_utils.hpp
…get_next function to work with iterators instead of pointers as samrec::pos_t
…light associated cost, because samrec::pos_t is iterators and not raw pointer
…rs. Resetting those iterators in the reset function for sam_file class
…iterators as samrec::pos_t
…s to iterators in the bamrec class and free function accessors
…erator and const_iterator types
…for extracting isize
…ting from falco::from_chars to std::from_chars
…ent a tautology when comparing with 255. Now get_next for samrec has types specified
… types in function signatures, moved definition of core_t to bam_core_t out of bamrec class and removed core_t member as it was only ever used in a narrow scope within one function
…al SAM records because I don't understand why the performance characteristics change so dramatically. Leaving this issue for next time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor pessimization of 1-2% seems to result from having functions generated for different underlying types within the function that collects results for each read. This depends on the compiler and is expected to be eliminated with future updates. Edit: The final change to using iterator of underlying vector for samrec is held back because I don't feel I fully understand it.