[Devourer] Don't register a background The Hunt under the APL action's name - #11846
Closed
taherbert wants to merge 1 commit into
Closed
[Devourer] Don't register a background The Hunt under the APL action's name#11846taherbert wants to merge 1 commit into
taherbert wants to merge 1 commit into
Conversation
…s name The Demonic Intensity cooldown holder added in b988001 was a the_hunt_t named "the_hunt". the_hunt_base_t looks its impact action up with get_background_action<the_hunt_damage_t>( "the_hunt" ), which found that holder and returned a null dynamic_cast, so The Hunt cast from an APL dealt no damage on any Demonic Intensity build. The cooldown object is created in the constructor and initialised by whichever of The Hunt or Predator's Wake the APL creates.
Saeldur
added a commit
that referenced
this pull request
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b988001 added a background
the_hunt_tfor Demonic Intensity builds so the shared cooldown object exists. It registers under the namethe_hunt, which is the keythe_hunt_base_tuses to look up its impact action viaget_background_action<the_hunt_damage_t>( "the_hunt" ). That lookup now finds the holder, thedynamic_castreturns nullptr, and The Hunt cast from an APL deals no damage on any Demonic Intensity build, on both Live and PTR data.Receipt (Devourer, Void-Scarred, 1T 300s): before the fix
the_huntreports 2.1 casts, nothe_hunt_damagechild and 0 damage; after, 493k per cast with the child present.The holder is not needed:
cooldown.the_huntis created in the constructor and initialised by whichever of The Hunt or Predator's Wake the APL creates, and both carry the 90s data.collapsing_star_t's reset on an unused cooldown is a no-op.