fix(workflow): improve selected edge visibility - #7183
Open
BillLeoutsakosvl346 wants to merge 3 commits into
Open
fix(workflow): improve selected edge visibility#7183BillLeoutsakosvl346 wants to merge 3 commits into
BillLeoutsakosvl346 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR improves selected-edge visibility and synchronizes transient edge selection with React Flow without persisting selection state.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains, and the previously reported import-convention issue is fixed at the current head.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx | Synchronizes React Flow edge-selection changes with transient canvas state and gates deletion controls by edit permission. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/workflow-canvas-helpers.ts | Adds stable context-aware selection keys and immutable application of edge-selection changes. |
| packages/workflow-renderer/src/edge/workflow-edge-view.tsx | Updates selected-edge appearance and renders an accessible delete control only when deletion is available. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/edge-highlight.test.ts | Tests direct edge highlighting and now follows the established application path-alias convention. |
Reviews (2): Last reviewed commit: "test(workflow): use edge highlight impor..." | Re-trigger Greptile
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Improves selected edge visibility with a full-opacity neutral highlight while preserving diff, execution, success, and error colors.
Synchronizes the transient edge-selection map with React Flow so mouse and keyboard selection, deselection, endpoint highlighting, z-order, and deletion stay aligned without persisting selection state.
Type of Change
Testing
bun run test -- workflow-edge-view-mount.test.tsx canvas-layers.test.tsinpackages/workflow-renderer— 25 passedbun run test -- workflow-canvas-helpers.test.ts edge-highlight.test.ts use-shift-selection-lock.test.tsxinapps/sim— 21 passedbun run type-checkinpackages/workflow-rendererbun run type-checkinapps/simChecklist
Screenshots/Videos
Proof screenshots are attached in the first PR comment.