Remove legacy incertae sedis

[vangberg]

Draft – #332 needs to be merged first.

We still have the legacy Name#incertae_sedis field in the database. In preparation for #173 I would like to remove it to reduce the number of edge cases we need to handle.

I have investigated the current state of Name#incertae_sedis in the production database:

There are 16 names with legacy incertae_sedis set:

irb(main):083> nx = Name.where.not(incertae_sedis: [nil, ""])
irb(main):084> nx.size
=> 16

All 16 records have a placement with either a parent or incertae_sedis, which can be verified by running the following:

Name.where.not(incertae_sedis: [nil, ""]).map {|n| [n[:incertae_sedis], n.placement.try(:parent).try(:name), n.placement.try(:incertae_sedis)]}

I interpret that as it being safe to drop this column from the database.

[vangberg]

I need to review if we can do this a bit simpler/re-use existing code.

[vangberg]

This is not great, but I think it is easier to handle it after we are done with the incertae sedis-related changes. Then we can either go with the Name#preferred_placement proposal or implement some shared Name#set_preferred_placement method.

[vangberg]

@lmrodriguezr Ready for review.

There are 16 name records in production with non-nil incertae_sedis. They all have at least one placement record, which means that the incertae_sedis from Name is never read, so I think it is safe to remove this column.

irb(main):008> nx = Name.where.not(incertae_sedis: [nil, ""])
=> 
[#<Name:0x0000735e803c7da8
...
irb(main):009> nx.size
=> 16
irb(main):010> nx.map {|n| n.placement.present?}
=> [true, true, true, true, true, true, true, true, true, true, true, true, true, true, true, true]

[vangberg]

This is not great, but I think it is easier to handle it after we are done with the incertae sedis-related changes. Then we can either go with the Name#preferred_placement proposal or implement some shared Name#set_preferred_placement method.