fix: resume and detach from targets we don't track - #623
Merged
Merged
Conversation
Auto-attach starts every target paused, and the attach handler skipped types outside `ALLOWED_TARGET_TYPES` before anything resumed them, so Chrome's two `browser_ui` targets per browser context stayed attached and paused for the lifetime of the browser.
route
force-pushed
the
fix/untracked-target-leak
branch
from
August 29, 2026 09:29
19b6d4c to
61c1e12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexts::ALLOWED_TARGET_TYPESexcludesbrowser_ui, but auto-attach is armed withwaitForDebuggerOnStart: true. Every target Chrome attaches starts paused.Chrome 152 opens two
chrome://omnibox-popup.top-chrome/(browser_ui) targets per browser context, so a plainFerrum::Browser.newleaks two sessions and each extra context adds two more.Untracked targets now go through
detach_untracked, which resumes the debugger and drops the session — the same treatment service workers already get.