ci: point the image builds at the real Dockerfile locations - #100
Merged
Conversation
The `Docker Build` job referenced `deploy/compose/Dockerfile.kernel` and
`deploy/compose/Dockerfile.worker`, but both files live in `deploy/docker/` -
the path `deploy/compose/docker-compose.yml` already uses. The job therefore
failed immediately:
ERROR: failed to build: failed to solve: failed to read dockerfile:
open Dockerfile.kernel: no such file or directory
It went unnoticed because the job only runs on pushes to main and needs
`backend-build` and `frontend-quality` first, so it was skipped for as long as
those were red.
Both images were built locally from these paths to confirm they succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second failure on
main, uncovered by #98. WithBackend BuildandFrontend Qualitygreen again, theDocker Buildjob ran for the first time in months — and failed instantly:The workflow pointed at
deploy/compose/Dockerfile.kernelanddeploy/compose/Dockerfile.worker, but the repository only has:deploy/compose/docker-compose.ymlalready uses the correctdeploy/docker/...paths, so the workflow was simply out of step.Why it stayed hidden
Docker Buildis gated ongithub.event_name == 'push' && github.ref == 'refs/heads/main'and needsbackend-buildandfrontend-quality. It is skipped on every pull request, and it was skipped onmaintoo for as long asFrontend Qualitywas failing. It only became reachable once #98 landed.Verification
The job cannot be exercised from a PR, so both images were built locally with the corrected paths: