feat: update home banner size and match its shimmer - #3143
Conversation
|
Now that the catalog loads ahead of the hero banner, we have a chance to improve UX in Android TV by shrinking both the banner and its shimmer just enough to expose the first catalog row immediately. Does adjusting the height make sense here, or do we prefer keeping the full-bleed banner as is? |
iAm-an-iA
changed the title
iAm-an-iA
changed the title
4d15742 to
be870c5
Compare
iAm-an-iA
changed the title
1787934832371.mp4Shimmer + Lazy Banner + Provider Cache example |
be870c5 to
76b913f
Compare
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
Everything looks good, except for the regular UI changes.
It is better to split unrelated features into multiple pull requests. Otherwise discussions about one feature may block the other feature. It also makes it more difficult to review.
| android:id="@+id/home_preview_info_btt" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="400dp" | ||
| android:layout_height="260dp" |
There was a problem hiding this comment.
Please keep UI changes in a separate pull request.
|
|
||
| private fun updatePreview(preview: Resource<Pair<Boolean, List<LoadResponse>>>) { | ||
| if (preview is Resource.Success) { | ||
| if (preview is Resource.Success || isLayout(TV or EMULATOR)) { |
There was a problem hiding this comment.
Better to keep this logic offloaded to getStatusBarHeight rather than define the behavior in both places.
3 participants
Summary
Fixes the initial loading skeleton on the Home screen to properly match the full-bleed Hero Banner redesign instead of the legacy 3-item carousel skeleton. This is crucial for improving user experience by eliminating jarring layout shifts and visual flickering, especially when content is cached or loads instantly—ensuring a seamless and smooth visual transition on app launch and provider switching.
Screenshot
TV
Phone