chore: release 10.56.0 - #638
Conversation
- proguard: keep `reload(java.lang.String)` with a wildcard return type on ReactHostImpl and every ReactHost implementation. RN's reload returns TaskInterface<Void>, so the `void reload(...)` rule from the audit matched nothing and an R8-minified new-architecture build renamed the method, making restartApp reject RESTART_FAILED. Found by the minified release build the audit asked for; every other JNI class, native method and reflection target was verified present in the R8 output. - check-packlist: accept npm 12's object-shaped `pack --json` output as well as the array older npm prints. - bump package.json and oh-package.json5 to 10.56.0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0149oHt3QpNA3XNocSBVFNCh
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe PR updates Android ProGuard coverage for ChangesRuntime and packaging updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This release update preserves reflective Android reload behavior, supports current npm pack output formats, and aligns package versions at 10.56.0. No merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Release prep for 10.56.0 (the audit PRs #635 / #637).
void reload(java.lang.String)forReactHostImpl, but RN'sreloadreturnsTaskInterface<Void>, so the rule matched nothing. In an R8-minified new-architecture build (RN 0.85,minifyEnabled true) the method was renamed andrestartAppwould rejectRESTART_FAILED. The rule now uses a***return type and also covers everyReactHostimplementation.minifyEnabled trueand inspected the R8 output (dexdump + mapping): the three JNI result classes keep their no-arg constructor and every field, all 11 native methods keep their names, and every reflection target (getReactDelegate,ReactDelegate.reactHost,ReactHostImpl.useDevSupport/reactHostDelegate/reload,DefaultReactHostDelegate.jsBundleLoader,MainApplication.getReactHost,BuildConfig.IS_NEW_ARCHITECTURE_ENABLED,ReactContext.hasActiveReactInstance) is present.ReactNativeHost/ReactInstanceManagerare empty shells in that app because the new-architecture template never instantiates them; those paths are old-arch only and guarded.check-packlist.jsaccepts npm 12's object-shapedpack --jsonoutput.package.jsonandharmony/pushy/oh-package.json5.🤖 Generated with Claude Code
https://claude.ai/code/session_0149oHt3QpNA3XNocSBVFNCh
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
Bug Fixes
Release Updates