Skip to content

Fix combined builds missing HTML output #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StanFromIreland merged 2 commits into from
Sep 5, 2026
Merged

Fix combined builds missing HTML output #354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d7ba57
Fix combined builds missing HTML output
StanFromIreland Sep 5, 2026
b68ff56
Apply batched suggestions from code review
StanFromIreland Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions build_docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,8 +756,14 @@ def build(self) -> None:
else:
maketarget = "autobuild-stable"
if self.html_only:
maketarget += "-html"
logging.info("Running make %s", maketarget)
maketargets = [f"{maketarget}-html"]
else:
maketargets = [maketarget]
if self.includes_html:
# The plain autobuild targets only build non-HTML
# (gh-139436), but a combined build needs HTML.
maketargets.append(f"{maketarget}-html")
logging.info("Running make %s", " ".join(maketargets))
python = self.venv / "bin" / "python"
sphinxbuild = self.venv / "bin" / "sphinx-build"
blurb = self.venv / "bin" / "blurb"
Expand Down Expand Up @@ -792,7 +798,7 @@ def build(self) -> None:
f"VENVDIR={self.venv}",
f"SPHINXOPTS={' '.join(sphinxopts)}",
"SPHINXERRORHANDLING=",
maketarget,
*maketargets,
))
self.log_directory.mkdir(parents=True, exist_ok=True)
chgrp(self.log_directory, group=self.group, recursive=True)
Expand Down