gh-108549: In asyncio, do not cancel the current task in Task.__step when a SystemExit exception was just raised - #156309
Open
YvesDup wants to merge 9 commits into
Open
Conversation
- Update `Task.__step` , - Update `_asyncio` module on the corresponding function, - Add a `test_step_dont_swallow_systemexit` test in `test_task.py` file.
YvesDup
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
August 24, 2026 07:52
2 tasks
Contributor
|
This needs a news entry and added comments should be on a single line each if they are short. |
Contributor
Author
|
@kumaraditya303 : Perharps this words are better for the news file: "Just before the wrapped coroutine is executed (via the |
Contributor
|
Please don't resolve comments until you have pushed changes for them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the
asyncio.Task.__stepmethod to prevent a newCancelledErrorto be set when the current task must be cancelled and aSystemExitor aKeybordInterruptexception is just raised.The fix should also be pplied in the
_asynciomodule.asyncio.gatherwith a single task raises an unexpectedCancelledErrorexception whenSystemExitoccurs in this task. #108549