Skip to content

Fix some "ruff check" warnings #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vstinner wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Fix some "ruff check" warnings #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion master/custom/builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
Windows64PGOTailcallBuild,
Windows64PGONoGilBuild,
Windows64PGONoGilTailcallBuild,
Windows64RefleakBuild,
Windows64ReleaseBuild,
MacOSArmWithBrewBuild,
MacOSArmWithBrewNoGilBuild,
Expand Down
7 changes: 4 additions & 3 deletions master/custom/release_dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ def decorated(*args, **kwargs):
raise _WrappedAttributeError(f'your error: {e!r}')
return decorated

class _WrappedAttributeError(Exception): pass
class _WrappedAttributeError(Exception):
pass


class DashboardObject:
Expand Down Expand Up @@ -447,9 +448,9 @@ def junit_results(self):
# We don't have a logger set up, this returns None on common failures
# (meaning failures won't show on the dashboard).
# TODO: set up monitoring and log failures (in the whole method).
except OSError as e:
except OSError:
return None
except ElementTree.ParseError as e:
except ElementTree.ParseError:
return None

result = JunitResult(self, {})
Expand Down