feat: show version in-app and polish the UI (0.2.4) - #33
Merged
Conversation
- Display the running version (v0.2.4) as a small accent pill next to the flow title, visible in hero and compact modes, plus the --version flag. - Replace the large rainbow ASCII logo and tagline in hero mode with a single clean, truly-centered 'flow v0.2.4' title for a more refined, consistent layout. - Make latency/interface status colors theme-consistent instead of hardcoded green/amber/red (accent highlights elevated latency or a down link). - Remove the green interface-status dot from the footer for a cleaner look. - Bump VERSION to 0.2.4; update CHANGELOG and README.
Contributor
Reviewer's GuideThis release wires the CLI version into the UI as an accent badge, replaces the hero artwork with a consistent centered title, and simplifies status styling by using active-theme colors while removing the footer status dot; release documentation and version metadata are updated accordingly. Sequence diagram for wiring the CLI version into the UIsequenceDiagram
participant CLI as flow CLI
participant UI as internal/ui
participant View as UI views
CLI->>UI: SetVersion(version)
CLI->>UI: New(...)
View->>UI: TitleRow(pulse)
UI-->>View: appVersion
View-->>CLI: centered title with versionBadge()
Flow diagram for the updated dashboard title and status stylingflowchart TD
Start[Render dashboard] --> Mode{Hero or compact mode?}
Mode -->|Both| Title[Render centered TitleRow]
Title --> Badge[Render versionBadge with active accent]
Badge --> Stats[Render latency with theme.Soft or theme.Accent]
Stats --> Link[Render interface state with theme.Soft or theme.Accent]
Link --> Footer[Render interface name and state without status dot]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning Review limit reachedNext included review available in 32 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (6)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CLI version changes to 0.2.4 and is passed to the UI. The dashboard shows the version in the title row, uses theme-consistent indicator colors, removes the footer status dot, and replaces the hero logo rendering. ChangesVersioned UI presentation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR updates the displayed version and refines the interface styling and layout without any identified merge-blocking risk; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant FlowCLI
participant UIModel
participant Dashboard
participant TitleRow
FlowCLI->>UIModel: SetVersion("0.2.4")
UIModel->>Dashboard: Provide appVersion
Dashboard->>TitleRow: Render title row
TitleRow-->>Dashboard: Show accent version badge
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="internal/ui/model.go" line_range="36-37" />
<code_context>
err error
}
+// appVersion is set from the main package via SetVersion so the UI can
+// surface it in the title and footer. Defaults to "dev" for local builds.
+var appVersion = "dev"
+
+// SetVersion records the build version for display inside the UI.
</code_context>
<issue_to_address>
**nitpick:** The comment says `appVersion` is surfaced in both the title and footer, but the version is rendered only by `TitleRow`; the footer continues to render only the interface name and state. The comment therefore falsely describes the UI behavior.
**Suggested fix:** Change the comment to say the version is surfaced in the title, or add the version to the footer if that is intended.
```suggestion
// appVersion is set from the main package via SetVersion so the UI can
// surface it in the title. Defaults to "dev" for local builds.
```
</issue_to_address>
### Comment 2
<location path="internal/ui/views.go" line_range="135-136" />
<code_context>
return strings.Count(strings.Join(lines, "\n"), "\n") + 1
}
+// versionBadge is no longer needed as a separate helper.
+// versionBadge renders the running version as a small accent-colored pill.
+func versionBadge() string {
+ return lipgloss.NewStyle().
+ Foreground(lipgloss.Color("#ffffff")).
</code_context>
<issue_to_address>
**nitpick:** The comment says `versionBadge` is no longer needed as a separate helper, but the helper is still defined and called by `TitleRow`. This contradicts the implementation and obscures the helper's actual purpose.
**Suggested fix:** Remove the obsolete first comment line and retain a description of what `versionBadge` renders.
```suggestion
// versionBadge renders the running version as a small accent-colored pill.
```
</issue_to_address>Sourcery assessment
Approved.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
- Restore the rainbow ASCII 'flow' logo and 'Calm your network. See it breathe.' tagline in hero mode, merged with a centered version pill (removed redundant '● flow' title line from hero). - Brighten the dim/muted text ramp across all built-in themes so every label stays clearly readable on black or transparent backgrounds. - Vietnamese: make the activity dot glow in compact and mini modes. - Fix Makefile demo target to reference demo.tape (was flow.tape). - Update CHANGELOG and README; regenerate assets/demo.gif.
The figlet/block logo once rendered as broken tofu because the tape requested 'JetBrains Mono', which isn't installed — only the Nerd Font variants are. Point the tape at 'JetBrainsMono Nerd Font Mono' so the box-drawing/block glyphs render aligned, and re-render the demo GIF plus the mode screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings the running version into the UI and polishes the layout toward a cleaner, more refined (Vercel/Linear-style) look.
Changes
v0.2.4) now renders as a small accent-colored pill right next to theflowtitle in hero and compact modes (so it's clearly the app version, not the interface). Still available viaflow --version.● flow v0.2.4title, consistent across hero and compact.Verification
go build ./...,go vet ./...,gofmt,golangci-lint(0 issues),go test ./...all pass.flow --versionreports0.2.4.Summary by Sourcery
Polish the dashboard UI and surface the application version across supported views.
New Features:
flow --versionsupport.Enhancements:
Build:
Documentation:
Chores:
Summary by CodeRabbit
New Features
flowtitle.flow --versionsupport for viewing the current version.Style
Documentation