Fixed PDO::CURSOR_SCROLL statements closing a cursor that was never declared - #23490
Open
KentarouTakeda wants to merge 1 commit into
Open
Fixed PDO::CURSOR_SCROLL statements closing a cursor that was never declared#23490KentarouTakeda wants to merge 1 commit into
KentarouTakeda wants to merge 1 commit into
Conversation
KentarouTakeda
requested review from
SakiTakamachi and
devnexen
as code owners
August 29, 2026 05:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The destructor of a statement created with
[PDO::ATTR_CURSOR => PDO::CURSOR_SCROLL]tries to close the cursor even when it has not been declared. This fixes that.The attempted close causes an error on the database server, but the destructor discards its result, so the error cannot be observed by the user. Apart from polluting the server's log, this is mostly harmless, but when it happens inside a transaction, it causes a strange situation where subsequent statements fail for a reason that cannot be observed.
The same implementation as the one added here already exists in
pgsql_stmt_execute(). This change makes the condition for issuingCLOSEon a cursor consistent withinpgsql_statement.c.