feat(2fa): audit second-factor events and notify the account owner - #3237
Merged
FrankApiyo merged 4 commits intoAug 27, 2026
Merged
FrankApiyo merged 4 commits into
FrankApiyo merged 4 commits into
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Second-factor lifecycle events now leave a trace. Confirming an enrolment writes a
two-factor-enrolledentry to the security audit log, and a failed code check — onverifyor on any code-guarded action — writestwo-factor-verification-failed. Enrolling and disabling both email the account owner, so whoever made the change, the owner finds out. Notification templates follow the account-lockout ones.Steps taken to verify this change does what is intended
Adopted the four tests from the outstanding-security-issues review, which were run and failing against this branch before the change. Template rendering verified locally through
get_two_factor_email_data.Side effects of implementing this change
None on API responses — audit entries and emails are added after the existing transactions commit, and the email is skipped for accounts with no address.
Before submitting this PR for review, please make sure you have:
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.