validate digits in numeric string exponent - #79
Merged
Merged
Conversation
nvms
approved these changes
Sep 13, 2026
nvms
left a comment
Owner
There was a problem hiding this comment.
Confirmed the bug against PHP 8.5 and ran the unit and compat suites on the branch. Thanks for the fix and the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In php 8.x, strings with an exponent indicator (
e/E) require at least one digit after the exponent or sign to be considered numeric strings. Strings like"0e","1e", or"1e+"must be treated as non-numeric.Previously,
Value.isNumericStringinsrc/runtime/value.zigconsumed the exponent marker without verifying that digits followed this caused false numeric comparisons such as:"0e" == 0returningtrue"1e" == "1"returningtrue"0e" <=> "0"returning0instead of1While
stdlib/types.zig's nativeis_numeric()already rejected these strings,Value.isNumericString()was missing the checkSolution
e/Eand optional+/-) inValue.isNumericStringfalseimmediately if no exponent digits were consumedTests
src/runtime/value.zigfor valid and invalid exponent casestests/numeric_string_exponent.phpmatching native php 8.x behavior