Move email notification from the listener to the agents - #6708
Open
evgenyrp wants to merge 8 commits into
Open
Conversation
evgenyrp
force-pushed
the
email-action-6664
branch
from
September 1, 2026 22:16
48a5841 to
b809cce
Compare
| MAX_PATCH_LINES = 400 | ||
|
|
||
|
|
||
| def record_email( |
Member
There was a problem hiding this comment.
Do we need a function where it can be passed as a agent tool?
| self.uploader, self.run_artifacts_dir, key, payload | ||
| ) | ||
|
|
||
| def _collect_changes(self) -> changes.ChangeSet | None: |
Member
There was a problem hiding this comment.
The caching here could be a bit tricky. If source_patch() gets called early in the process for any reason, this will not reflect the final tree changes.
What if we ready patch at send time in the handler from the GCS, similar to what we do with submit to Phab? Then we do not need to keep two copies of the same patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6664
fixes #6269