fix(qoder): skip reserved environment metadata - #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent Qoder environment updates from sending the provider-managed
created_bymetadata field.Why
Qoder includes
created_byin environment read responses but rejects that reserved key on writes, including{ created_by: null }. The update path previously tombstoned every undeclared non-agents.*metadata key, causing otherwise valid environment updates to fail with HTTP 400.Type
Surface area
Checklist
bun run verify:fullpassesBehavior / risk
Qoder environment updates now leave the provider-managed
created_byfield untouched while continuing to tombstone removed user metadata. This is narrowly scoped to the Qoder environment update request.Validation
bun test packages/sdk/tests/e2e/qoder-adapter-pagination.test.tsbun run verify:scopedbun scripts/verify.ts pushagents apply: environment, template, and channel updates completed successfully after the fix.