chore(ui-react): keep the BRANDING comment with the key it explains - #115
Merged
Conversation
The prose sat above the conditional, so an unbranded deployment shipped six lines of comment about a key its ConfigMap does not contain. The other optional keys put their prose outside the conditional, but they are emitted almost always: EXECUTION_ENGINE and DATA_CATALOG_API both fall back to a derived value. BRANDING defaults to empty, so absent is its common case. No key changes. Left for the next release rather than a version of its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up polish to #114. No rendered key changes, so no version bump — it rides the
next release.
An unbranded deployment (
components.ui_react.config.brandingempty, the default) renderedthe six-line comment with no
BRANDINGkey under it. The comment now sits inside thewithblock, and a# Presentation.group header invalues.yamlstops the key reading aspart of the auth cluster above it.
Refs mintproject/monorepo#207