Skip to content

Clear default unittestArgs for test discovery and execution - #26121

Open
Kamil Paduszyński (paduszyk) wants to merge 2 commits into
microsoft:mainfrom
paduszyk:django-test-discovery-incompatible-arguments
Open

Clear default unittestArgs for test discovery and execution#26121
Kamil Paduszyński (paduszyk) wants to merge 2 commits into
microsoft:mainfrom
paduszyk:django-test-discovery-incompatible-arguments

Conversation

@paduszyk

Copy link
Copy Markdown

@paduszyk

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@bschnurr

Bill Schnurr (bschnurr) commented Aug 28, 2026

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

Comment thread package.json
@@ -719,13 +719,7 @@
"type": "string"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning · Non-blocking recommendation

Clearing these arguments changes the effective discovery pattern from *test*.py to unittest's native test*.py. Projects that relied on suffix-named files such as example_test.py being discovered with the extension defaults will stop finding them. Please add regression coverage for this compatibility decision, or preserve the previous behavior if the narrower pattern is not intended.

@bschnurr

Copy link
Copy Markdown
Member

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Result: could-not-verify

Summary: The PR updates existing unit and end-to-end tests to exercise unittest discovery and execution with empty arguments. No new test cases were added. Tests could not run because no trusted sandbox image is configured for `microsoft/vscode-python`, and local execution was not authorized.

Test runs: 3 not run

  • ⚠️ Not run | Unittest adapter unit suites | npm run test:unittests -- --grep "Unittest test discovery adapter|Execution Flow Run Adapters"
  • ⚠️ Not run | Test adapter end-to-end suite | VSC_PYTHON_CI_TEST_GREP='End to End Tests: test adapters' npm run testSingleWorkspace
  • ⚠️ Not run | Dependency and test discovery preflight | git --no-pager diff --name-status upstream/main...HEAD && printf '\n--- package scripts ---\n' && node -e "const p=require('.\package.json'); for (const [k,v] of Object.entries(p.scripts||{})) if (/test|compile/.test(k)) console.log(k+'='+v)" && printf '\n--- dependency state ---\n' && if [ -d node_modules ]; then echo node_modules=present; else echo node_modules=missing; fi && node --version && npm --version
⚠️ Unittest adapter unit suites diagnostic output
Verification container was unavailable.
⚠️ Test adapter end-to-end suite diagnostic output
Verification container was unavailable.
⚠️ Dependency and test discovery preflight diagnostic output
Container verification could not start: no trusted sandbox image is configured for microsoft/vscode-python. Local execution was not authorized for this PR HEAD.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Aug 28, 2026
@bschnurr

Copy link
Copy Markdown
Member

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Result: could-not-verify

Summary: Verification could not start because no trusted sandbox image is configured for `microsoft/vscode-python`, and local execution was not authorized. The relevant unit and functional suites therefore remain unexecuted. The PR modifies existing tests but adds no new test cases; the modified coverage exercises empty unittest arguments for discovery and execution.

Test runs: 3 not run

  • ⚠️ Not run | Unittest discovery and execution adapter unit suites | npm run test:unittests -- --grep "Unittest test discovery adapter|Execution Flow Run Adapters"
  • ⚠️ Not run | Test adapter functional suite | npm run test:functional -- --grep "End to End Tests: test adapters"
  • ⚠️ Not run | Dependency and test-discovery preflight | printf '%s\n' '=== sandbox profile ==='; printf '%s\n' "${AUTOMATION_SANDBOX_PROFILE:-<unset>}"; printf '%s\n' '=== refs ==='; git branch -a --no-color; printf '%s\n' '=== changed files ==='; git diff --name-status HEAD^ HEAD; printf '%s\n' '=== changed tests ==='; git diff --unified=0 HEAD^ HEAD -- 'src/test/**/*.test.ts'; printf '%s\n' '=== test scripts ==='; node -e "const p=require('./package.json'); for (const [k,v] of Object.entries(p.scripts||{})) if (/test|compile/.test(k)) console.log(k+'='+v)"; printf '%s\n' '=== dependency state ==='; if [ -d node_modules ]; then echo 'node_modules=present'; else echo 'node_modules=missing'; fi; if [ -x node_modules/.bin/mocha ]; then echo 'mocha=present'; else echo 'mocha=missing'; fi
⚠️ Unittest discovery and execution adapter unit suites diagnostic output
Container verification could not start: no trusted sandbox image is configured for microsoft/vscode-python.
⚠️ Test adapter functional suite diagnostic output
Container verification could not start: no trusted sandbox image is configured for microsoft/vscode-python.
⚠️ Dependency and test-discovery preflight diagnostic output
Container verification could not start and local execution was not authorized for this PR HEAD: No trusted sandbox image is configured for microsoft/vscode-python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Django test discovery passes incompatible default arguments to manage.py test

3 participants