Fix scrollable native REPL - #26090
Conversation
a7bd46c to
6f60c00
Compare
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
| ]); | ||
| const stdoutItem = vscode.NotebookCellOutputItem.stdout(result.output); | ||
| (stdoutItem as any).metadata = { scrollable: false }; | ||
| const output = new vscode.NotebookCellOutput([stdoutItem], { scrollable: false }); |
There was a problem hiding this comment.
Warning · Non-blocking recommendation
Add a native-REPL regression test using long output to verify that the notebook output remains non-scrollable through VS Code's notebook API.
[unverified]
|
Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Result: Summary: The PR changes REPL output construction to disable scrolling, but adds no tests covering that behavior. Existing REPL tests stub `createReplController` and do not exercise its output metadata. The verification container could not start, and local execution was unauthorized, so no meaningful tests ran. Static inspection identified a concrete coverage gap. Test runs: 1 not run
|
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
|
Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Result: Summary: Targeted verification could not run because no trusted sandbox image is configured for `microsoft/vscode-python`. The existing Native REPL tests stub `createReplController`, so they do not exercise the changed output construction. No new tests were added for the new stdout and non-scrollable metadata behavior. Test runs: 1 not run
|
I had GitHub Copilot hammer at this one for quite awhile. I tested it and it does in fact work for me. Copilot did write some tests but I wanted to start with this to see if a fix like this could even be accepted.