Skip to content

chat: avoid redundant environment tool confirmation - #26072

Open
Eleanor Boyd (eleanorjboyd) wants to merge 3 commits into
microsoft:mainfrom
eleanorjboyd:agents/allow-all-tool-cal-issue
Open

chat: avoid redundant environment tool confirmation#26072
Eleanor Boyd (eleanorjboyd) wants to merge 3 commits into
microsoft:mainfrom
eleanorjboyd:agents/allow-all-tool-cal-issue

Conversation

@eleanorjboyd

Copy link
Copy Markdown
Member

Summary

  • remove the extra confirmation shown before the Python environment picker
  • preserve the picker's explicit user selection before creating or selecting an environment
  • add regression coverage ensuring the tool does not request confirmation during preparation

Why

The contributed configurePythonEnvironment tool always returned confirmationMessages, which caused Copilot CLI sessions to stop for approval even when Allow all was enabled. The environment picker already requires the user to explicitly choose an environment action, so the preceding confirmation was redundant.

The environment picker already requires an explicit user choice, so an additional tool confirmation blocks Allow All sessions unnecessarily.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bschnurr

Bill Schnurr (bschnurr) commented Aug 28, 2026

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Copy link
Copy Markdown
Member

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Result: could-not-verify

Summary: The PR adds focused coverage for removing preparation confirmation while retaining the explicit environment picker. No tests could execute because the verification container image was unavailable. The regression test therefore remains unverified.

Test runs: 1 not run

  • ⚠️ Not run | Verification preflight and test discovery | printf '%s\n' '--- changed files ---' && git --no-pager diff --name-status upstream/main...HEAD && printf '%s\n' '--- dependency state ---' && if [ -d node_modules ]; then echo 'node_modules=present'; else echo 'node_modules=missing'; fi && printf 'AUTOMATION_SANDBOX_PROFILE=%s\n' "${AUTOMATION_SANDBOX_PROFILE:-}" && printf '%s\n' '--- relevant npm scripts ---' && node -e "const p=require('./package.json'); for (const [k,v] of Object.entries(p.scripts||{})) if (/test|compile|typecheck/.test(k)) console.log(k+'='+v)" && printf '%s\n' '--- test runner grep handling ---' && sed -n '1,110p' src/test/unittests.ts && sed -n '1,95p' src/test/index.ts
⚠️ Verification preflight and test discovery diagnostic output
Container verification could not start: no trusted sandbox image is configured for microsoft/vscode-python, and local execution was not authorized.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Aug 28, 2026
@bschnurr

Copy link
Copy Markdown
Member

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Result: could-not-verify

Summary: The PR adds one regression test covering removal of the preparation confirmation. No tests could run because the verification container image for `microsoft/vscode-python` was unavailable and local execution was unauthorized. The change therefore could not be meaningfully verified.

Test runs: 1 not run

  • ⚠️ Not run | Dependency and test discovery | git status --short && git diff --name-status "$(git merge-base HEAD upstream/main)" HEAD && node -e "const p=require('./package.json'); console.log(JSON.stringify(Object.fromEntries(Object.entries(p.scripts).filter(([k,v])=>/test|compile/.test(k)||/mocha|standardTest/.test(v))),null,2)); console.log('node_modules=' + require('fs').existsSync('node_modules')); console.log('sandbox_profile=' + (process.env.AUTOMATION_SANDBOX_PROFILE || ''));"
⚠️ Dependency and test discovery diagnostic output
Container verification could not start: no trusted sandbox image is configured for microsoft/vscode-python. Local execution was not authorized for this PR HEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug review-auto:approved Automated review: no blocking findings (approval posted). skip tests Updates to tests unnecessary skip-issue-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants