Fix custom configuration provider regression - #14725
Fix custom configuration provider regression#14725Sean McManus (sean-mcmanus) wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation restores prior provider behavior and includes targeted regression coverage.
Pull request overview
Restores per-URI provider initialization and filtering while retaining batched configuration requests.
Changes:
- Calls
canProvideConfigurationbefore batching supported URIs. - Adds integration coverage for provider initialization ordering.
File summaries
| File | Description |
|---|---|
Extension/src/LanguageServer/client.ts |
Filters and initializes URIs before requesting configurations. |
Extension/test/scenarios/SimpleCppProject/tests/languageServer.integration.test.ts |
Verifies initialization precedes configuration provisioning. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sean McManus (sean-mcmanus)
left a comment
There was a problem hiding this comment.
✨Copilot (agent50): Reviewed source e7240568 merged over main at 2f25880c (provider merge 79b663e2; parents confirmed).
Root cause verified rather than assumed: #14582 removed the canProvideConfiguration call, and the provider named in #14724 populates its foundFiles cache as a side effect of that call, so its provideConfigurations returned an empty array and IntelliSense fell back to the host compiler with no provider include paths. Restoring the call before the batched request fixes that, and the restored semantics match the pre-#14582 code exactly — including the subtle case where a thrown canProvideConfiguration still leaves the URI treated as supported. Filtering to supportedUris is safe for partial batches, since sendCustomConfigurations is keyed per URI.
Two non-blocking comments below. I could not run the SimpleCppProject scenario locally (extension dependencies and native test binaries are not deployed in this worktree), so the test change is reviewed statically; current-head CI covers compile, lint, and unit tests only.
Summary
Restore
canProvideConfigurationcalls for each requested URI before invoking the batchedprovideConfigurationsrequest. This preserves provider initialization and filtering behavior while retaining the multi-file batching introduced in #14582.Add integration coverage for a provider that prepares its file configuration during
canProvideConfiguration, and run the containingSimpleCppProjectscenario in CI on Windows, Linux, and macOS.Fixes #14724.