Skip to content

Type HTMLImageElement.crossOrigin as a literal union of known CORS values #64179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+140 −1
Draft

Type HTMLImageElement.crossOrigin as a literal union of known CORS values #64179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dad0ad9
Initial plan
Copilot Sep 5, 2026
47fa65a
Add failing test for HTMLImageElement.crossOrigin
Copilot Sep 5, 2026
100391c
Type HTMLImageElement.crossOrigin as literal union of CORS values
Copilot Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tsc/internal/bundled/libs/lib.dom.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18597,7 +18597,7 @@ interface HTMLImageElement extends HTMLElement {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/crossOrigin)
*/
crossOrigin: string | null;
crossOrigin: "anonymous" | "use-credentials" | "" | null;
/**
* The **`currentSrc`** read-only property of the HTMLImageElement interface indicates the URL of the image selected by the browser to load.
*
Expand Down
16 changes: 16 additions & 0 deletions tsc/testdata/baselines/reference/compiler/htmlImageElementCrossOrigin.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
htmlImageElementCrossOrigin.ts(7,1): error TS2322: Type '"abc"' is not assignable to type '"" | "anonymous" | "use-credentials" | null'.


==== htmlImageElementCrossOrigin.ts (1 errors) ====
const img = new Image(10, 10);

img.crossOrigin = "anonymous";
img.crossOrigin = "use-credentials";
img.crossOrigin = "";
img.crossOrigin = null;
img.crossOrigin = "abc";
~~~~~~~~~~~~~~~
!!! error TS2322: Type '"abc"' is not assignable to type '"" | "anonymous" | "use-credentials" | null'.

const value: "anonymous" | "use-credentials" | "" | null = img.crossOrigin;

23 changes: 23 additions & 0 deletions tsc/testdata/baselines/reference/compiler/htmlImageElementCrossOrigin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
//// [tests/cases/compiler/htmlImageElementCrossOrigin.ts] ////

//// [htmlImageElementCrossOrigin.ts]
const img = new Image(10, 10);

img.crossOrigin = "anonymous";
img.crossOrigin = "use-credentials";
img.crossOrigin = "";
img.crossOrigin = null;
img.crossOrigin = "abc";

const value: "anonymous" | "use-credentials" | "" | null = img.crossOrigin;


//// [htmlImageElementCrossOrigin.js]
"use strict";
const img = new Image(10, 10);
img.crossOrigin = "anonymous";
img.crossOrigin = "use-credentials";
img.crossOrigin = "";
img.crossOrigin = null;
img.crossOrigin = "abc";
const value = img.crossOrigin;
38 changes: 38 additions & 0 deletions tsc/testdata/baselines/reference/compiler/htmlImageElementCrossOrigin.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
//// [tests/cases/compiler/htmlImageElementCrossOrigin.ts] ////

=== htmlImageElementCrossOrigin.ts ===
const img = new Image(10, 10);
>img : Symbol(img, Decl(htmlImageElementCrossOrigin.ts, 0, 5))
>Image : Symbol(Image, Decl(lib.dom.d.ts, --, --))

img.crossOrigin = "anonymous";
>img.crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))
>img : Symbol(img, Decl(htmlImageElementCrossOrigin.ts, 0, 5))
>crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))

img.crossOrigin = "use-credentials";
>img.crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))
>img : Symbol(img, Decl(htmlImageElementCrossOrigin.ts, 0, 5))
>crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))

img.crossOrigin = "";
>img.crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))
>img : Symbol(img, Decl(htmlImageElementCrossOrigin.ts, 0, 5))
>crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))

img.crossOrigin = null;
>img.crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))
>img : Symbol(img, Decl(htmlImageElementCrossOrigin.ts, 0, 5))
>crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))

img.crossOrigin = "abc";
>img.crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))
>img : Symbol(img, Decl(htmlImageElementCrossOrigin.ts, 0, 5))
>crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))

const value: "anonymous" | "use-credentials" | "" | null = img.crossOrigin;
>value : Symbol(value, Decl(htmlImageElementCrossOrigin.ts, 8, 5))
>img.crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))
>img : Symbol(img, Decl(htmlImageElementCrossOrigin.ts, 0, 5))
>crossOrigin : Symbol(HTMLImageElement.crossOrigin, Decl(lib.dom.d.ts, --, --))

50 changes: 50 additions & 0 deletions tsc/testdata/baselines/reference/compiler/htmlImageElementCrossOrigin.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
//// [tests/cases/compiler/htmlImageElementCrossOrigin.ts] ////

=== htmlImageElementCrossOrigin.ts ===
const img = new Image(10, 10);
>img : HTMLImageElement
>new Image(10, 10) : HTMLImageElement
>Image : new (width?: number, height?: number) => HTMLImageElement
>10 : 10
>10 : 10

img.crossOrigin = "anonymous";
>img.crossOrigin = "anonymous" : "anonymous"
>img.crossOrigin : "" | "anonymous" | "use-credentials" | null
>img : HTMLImageElement
>crossOrigin : "" | "anonymous" | "use-credentials" | null
>"anonymous" : "anonymous"

img.crossOrigin = "use-credentials";
>img.crossOrigin = "use-credentials" : "use-credentials"
>img.crossOrigin : "" | "anonymous" | "use-credentials" | null
>img : HTMLImageElement
>crossOrigin : "" | "anonymous" | "use-credentials" | null
>"use-credentials" : "use-credentials"

img.crossOrigin = "";
>img.crossOrigin = "" : ""
>img.crossOrigin : "" | "anonymous" | "use-credentials" | null
>img : HTMLImageElement
>crossOrigin : "" | "anonymous" | "use-credentials" | null
>"" : ""

img.crossOrigin = null;
>img.crossOrigin = null : null
>img.crossOrigin : "" | "anonymous" | "use-credentials" | null
>img : HTMLImageElement
>crossOrigin : "" | "anonymous" | "use-credentials" | null

img.crossOrigin = "abc";
>img.crossOrigin = "abc" : "abc"
>img.crossOrigin : "" | "anonymous" | "use-credentials" | null
>img : HTMLImageElement
>crossOrigin : "" | "anonymous" | "use-credentials" | null
>"abc" : "abc"

const value: "anonymous" | "use-credentials" | "" | null = img.crossOrigin;
>value : "" | "anonymous" | "use-credentials" | null
>img.crossOrigin : "" | "anonymous" | "use-credentials" | null
>img : HTMLImageElement
>crossOrigin : "" | "anonymous" | "use-credentials" | null

12 changes: 12 additions & 0 deletions tsc/testdata/tests/cases/compiler/htmlImageElementCrossOrigin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// @lib: es5,dom
// @strict: true

const img = new Image(10, 10);

img.crossOrigin = "anonymous";
img.crossOrigin = "use-credentials";
img.crossOrigin = "";
img.crossOrigin = null;
img.crossOrigin = "abc";

const value: "anonymous" | "use-credentials" | "" | null = img.crossOrigin;