Conversation
…notice The newsletter notice named Mad Mimi as the third-party provider the email address is shared with. That company no longer exists, so the installer pointed users at a provider that is gone, and the sentence carried no useful information beyond the name anyway. Also fixes the "use your it" typo in the same string.
Weblate keeps serving an existing translation after the English source changes, so leaving the 28 translations untouched would keep showing the old provider name to everyone not using English - two of them misspell it as "Mad Mini", Gujarati and Tamil transliterate it, and Finnish makes the same sharing claim without naming anyone. Dropping just that sentence keeps the translations usable instead of falling back to English, and the remaining sentences stand on their own in every locale.
sgiehl
marked this pull request as ready for review
August 27, 2026 12:48
sgiehl
added
the
not-in-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the On-Premise installation, the newsletter privacy notice told users their email address is shared with Mad Mimi. That provider no longer exists, so the installer named a company that is gone — a poor first impression for a privacy product. The sentence carried no information beyond the provider name, so it is removed rather than reworded.
Installation_EmailPrivacyNoticenow reads: "Your email address will only be used to send you the newsletter. We will not share it with anyone else or use it for any other purpose. You can unsubscribe at any time. See our %1$sprivacy policy%2$s for more information." The key name and its two-placeholder contract are unchanged, and theuse your ittypo in the old string is fixed.FetchTranslationsdownloads the whole file from Weblate, so an existing translation keeps being served after the English source changes — leaving them untouched would keep showing the dead provider to everyone not using English. Two locales misspell it as Mad Mini (de,it), Gujarati and Tamil transliterate it (મેડ મીમી,மேட் மிமி),es-arsplits the claim over two sentences, andfimakes the same sharing claim without naming anyone — all handled.Dropping only that sentence keeps every locale on its own translation instead of falling back to English, and the remaining sentences stand on their own in each. Verified per file: one changed line, still valid JSON, placeholder counts unchanged, no double or stray whitespace.
Hand-editing Weblate-managed files is unusual for core, so please sanity-check that choice — the alternative (a new key) would have dropped all 28 locales to English text until translators picked it up.
The three
Installation_superuser*expected screenshots are updated for the shorter notice, synced from the CI artifacts. The German one still renders German (the cleaned translation), not an English fallback.AI Checklist