SH-1113 Fail CI when a PR description contains a GitHub closing keyword - #43
Merged
Merged
Conversation
Issues here are synced with Linear. A closing keyword closes the GitHub issue at merge time while Linear's PR automation moves the linked issue to Self QA, and the two automations then close, reopen, and re-triage the issue in public. Reference issues with "Refs #123" and close them from Linear instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CI check that fails when a PR description contains a GitHub closing keyword (close/fix/resolve followed by an issue reference).
Issues in this repo are synced with Linear. A closing keyword closes the GitHub issue the moment the PR merges, while Linear's PR automation moves the linked Linear issue to Self QA at the same time. The two automations then fight: the GitHub issue is closed, reopened (with the e-mail noise that brings for the reporter), and the Linear issue ends up back in Triage. This has happened on every synced issue since July whose PR used a closing keyword, across several of our public repos.
The convention going forward: reference the issue with
Refs #123and close it from Linear (Done) or by hand once the fix is released.Notes:
Linear: SH-1113