feat: add remaining feature commands - #3984
Open
ikegami-t wants to merge 6 commits into
Open
Conversation
Contributor
Author
ikegami-t
force-pushed
the
feat-remain-cmds
branch
2 times, most recently
from
September 6, 2026 15:46
8a7c6fe to
a3d9e9f
Compare
Contributor
Author
|
Still considering to add async-event-fonf command fields options instead of the |
igaw
reviewed
Sep 7, 2026
| NVME_FEAT_RATE_LIMITING_TGT_MASK = 0xff, | ||
| }; | ||
|
|
||
| // IRQ Coalescing Feature - Shift and Mask definitions |
Collaborator
There was a problem hiding this comment.
Can you add kdoc documentation here?
Contributor
Author
There was a problem hiding this comment.
As commented below the definitions are not necessary then deleted. Thank you.
igaw
reviewed
Sep 7, 2026
| NVME_FEAT_IRQ_COAL_THR_MASK = 0xff, | ||
| NVME_FEAT_IRQ_COAL_TIME_SHIFT = 8, | ||
| NVME_FEAT_IRQ_COAL_TIME_MASK = 0xff, | ||
| }; |
Collaborator
There was a problem hiding this comment.
And the GET macros are missing for these.
Collaborator
There was a problem hiding this comment.
BTW, the nvme-cli-ai project can help here. See the nvme-spec skill for this.
Contributor
Author
There was a problem hiding this comment.
Sorry already existed NVME_FEAT_IRQC_***_SHIFT/MACRO definitions, etc. then just deleted the definitions as duplicated. Thanks for the information I will do use it in future.
Almost implementation suggested by Copilot. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Commit the update-completions changes. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Since called set features command. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Add the feature print getters to replace open coded field decoding. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Also fix to add to the ANSAN field print missed. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
This is to combine json and stdout strings duplicated. Also add json TTHRY field output missed. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
feat-remain-cmds
branch
from
September 7, 2026 16:31
a3d9e9f to
9011175
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost implementation suggested by Copilot.