Skip to content

fix: Accept any numeric tracking event value #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kinyoklion wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Draft

fix: Accept any numeric tracking event value #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/launchdarkly/openfeature/serverprovider/Provider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ public void track(String eventName, EvaluationContext ctx, TrackingEventDetails
if (details != null) {
Double metricValue = null;
if (details.getValue().isPresent()) {
metricValue = (Double) details.getValue().get();
metricValue = details.getValue().get().doubleValue();
}
// Convert the Structure portion of the TrackingEventDetails into a key value
// map.
Expand Down
21 changes: 21 additions & 0 deletions src/test/java/com/launchdarkly/openfeature/serverprovider/ProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,4 +214,25 @@ public void itCanTrackFullTrackingEventDetails() {
valueConverter.toLdValue(new Value(trackingEventDetails)),
99.77);
}

@Test
public void itCanTrackAnIntegerTrackingEventValue() {
EvaluationContext evaluationContext = new ImmutableContext("user-key");
EvaluationContextConverter evaluationContextConverter = new EvaluationContextConverter(null);
ValueConverter valueConverter = new ValueConverter(null);

TrackingEventDetails trackingEventDetails = new MutableTrackingEventDetails(99).add("currency", "USD");

OpenFeatureAPI.getInstance().setProvider(ldProvider);

OpenFeatureAPI
.getInstance()
.getClient().track("metric-key", evaluationContext, trackingEventDetails);

verify(mockedLdClient).trackMetric(
"metric-key",
evaluationContextConverter.toLdContext(evaluationContext),
valueConverter.toLdValue(new Value(trackingEventDetails)),
99.0);
}
}
Loading