Skip to content

chore: bump CI LuaRocks and install-boost pins to latest - #127

Open
devin-ai-integration[bot] wants to merge 2 commits into
mainfrom
devin/1786957518-luarocks-3-13
Open

chore: bump CI LuaRocks and install-boost pins to latest#127
devin-ai-integration[bot] wants to merge 2 commits into
mainfrom
devin/1786957518-luarocks-3-13

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Keeps the CI/build tooling pins for this repo on the latest release within their current major.

  • LuaRocks pin used by CI and install-lua-sdk bumped 3.12.03.13.0 (latest LuaRocks release).
  • MarkusJx/install-boost pin bumped v2.4.4v2.6.0 (latest v2; Node 24 runtime), with boost_version: 1.81.0 / platform_version: "22.04" unchanged.
  • C++ Server-side SDK (3.13.1) and Redis Source (2.4.1) are already at latest in .github/variables/cpp-sdk-versions.env and the example Dockerfiles — no change.
  • README "Minimum Version" entries (3.9.0 / 2.1.19) intentionally left alone: newer versions work but are not required.
  • No shipped code changes, so this stays chore: and is not releasable.

Requirements

  • I have added test coverage for new or changed functionality (CI/build-config only; existing test suite covers it)
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions (CI runs 5.1/5.2/5.3/luajit-2.1; local validation on Lua 5.3)

Related issues

None — routine dependency audit of this repo and its examples.

Implementation details

Why these two pins

Both are exact pins of build tooling that CI actually uses, so per our version policy they get bumped to the latest release within the same major. LuaRocks 3.13.0 is the newest release; install-boost v2.6.0 is the newest v2 (its only change over v2.5.1 is moving the action runtime to Node 24, which keeps it off the deprecated Node 20 runtime). No action inputs changed, and Boost stays at 1.81.0 because the C++ SDK's prebuilt Linux dynamic artifacts are built against it (apt Boost on newer distros is too new).

Not changed

  • hello-nginx OpenResty base image (1.21.4.1-0-jammy) is deliberately pinned with an in-file comment about an OpenSSL incompatibility — left alone.
  • luarocks/gh-actions-lua (v10) and luarocks/gh-actions-luarocks (v5) SHA pins: newer releases are major bumps (v14 / v7), which are out of scope for a within-major update.
  • README documented minimums, per "requires ≠ works with".

Testing

  • Built the hello-debian example image locally (docker build --build-arg CPP_SDK_VERSION=3.13.1 -f examples/hello-debian/Dockerfile .): C++ server SDK 3.13.1 compiled from source and luarocks make launchdarkly-server-sdk-2.2.0-0.rockspec succeeded with no compiler warnings and no deprecation warnings.
  • Ran the example against the hello-apps environment SDK key: The hello-boolean feature flag evaluates to true.
  • Ran the unit suite inside that image (lua test.lua): Ran 20 tests in 0.242 seconds, 20 successes, 0 failures.
  • Repo CI on this branch was green on the previous commit (all linux-build matrix legs, hello-debian, hello-nginx, hello-haproxy), except the org's "Require additional human oversight on bot PRs" gate, which always stays red for bot PRs.
  • Only runtime noise is an upstream C++ SDK message in the Debian image: [LaunchDarkly] event-processor couldn't load en_US.utf-8 locale (locale not installed in the base image; no repo-side fix needed).

Link to Devin session: https://app.devin.ai/sessions/e8794c31d60544ab9cc3d858005c0d76
Open in Devin Desktop: https://app.devin.ai/desktop/session/e8794c31d60544ab9cc3d858005c0d76?variant=devin


Note

Overview
Updates CI-only dependency pins in the shared CI composite action (.github/actions/ci/action.yml) and the install-lua-sdk workflow so builds use current within-major tooling.

LuaRocks is pinned from 3.12.0 to 3.13.0 in both places. MarkusJx/install-boost moves from v2.4.4 to v2.6.0 (new commit SHA); boost_version: 1.81.0 and platform_version: "22.04" are unchanged. No application or SDK source changes.

Reviewed by Cursor Bugbot for commit de52477. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

@cursor review

Keeps the Boost installer on the latest v2 release (Node 24 runtime); boost_version and platform_version inputs are unchanged.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration devin-ai-integration Bot changed the title chore: bump CI LuaRocks pin to 3.13.0 chore: bump CI LuaRocks and install-boost pins to latest Aug 31, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

@cursor review

@kinyoklion
kinyoklion marked this pull request as ready for review August 31, 2026 23:01
@kinyoklion
kinyoklion requested a review from a team as a code owner August 31, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant