generate-defconfig: handle missing trailing newline - #1604
Merged
Conversation
merge_config.sh appends each file with cat, which inserts nothing between files. A file that does not end with a newline therefore sticks its last line to the first line of the next. Like: BR2_PACKAGE_FOO=yBR2_ROOTFS_OVERLAY="..." Kconfig cannot parse that, so both settings are silently dropped and the generated defconfig keeps the base value instead. This commit concatenate the fragments with awk. This terminates every line, so the result no longer depends on how the input files ends. Signed-off-by: Richard Alpe <richard@bit42.se>
troglobit
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
merge_config.sh appends each file with cat, which inserts nothing between files. A file that does not end with a newline therefore sticks its last line to the first line of the next. Like:
BR2_PACKAGE_FOO=yBR2_ROOTFS_OVERLAY="..."
Kconfig cannot parse that, so both settings are silently dropped and the generated defconfig keeps the base value instead.
This commit concatenate the fragments with awk. This terminates every line, so the result no longer depends on how the input files ends.
Checklist
Tick relevant boxes, this PR is-a or has-a: