Recover WebMCP sessions after missed events - #360
Merged
Conversation
sjmiller609
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Target.getTargets, removing stale sessions and their WebMCP registrations even when a destroy event is missedWhy
Browser-surface reconciliation recovered failed target attachment and missing page targets, but two terminal paths only cleared bookkeeping flags. A session that exhausted initialization could remain permanently ineligible for reattachment, while a missed iframe destroy event could leave stale tools discoverable.
Testing
go test -race -count=100 ./lib/browsersurfacego test -race -count=20 ./lib/browsersurface ./lib/webmcpclientgo vet ./...go test -race