Support PostgreSQL connection secrets - #32
Draft
iplay88keys wants to merge 3 commits into
Draft
iplay88keys wants to merge 3 commits into
iplay88keys wants to merge 3 commits into
Conversation
iplay88keys
marked this pull request as draft
September 4, 2026 19:48
iplay88keys
marked this pull request as ready for review
September 4, 2026 20:24
EItanya
force-pushed
the
main
branch
3 times, most recently
from
September 10, 2026 21:46
971d345 to
007eb1e
Compare
teemow
added a commit
to giantswarm/substrate
that referenced
this pull request
Sep 11, 2026
…agent-dev#32), atelet scheduling knobs
teemow
added a commit
to giantswarm/substrate
that referenced
this pull request
Sep 11, 2026
…agent-dev#32), atelet scheduling knobs
9 tasks
teemow
added a commit
to giantswarm/substrate
that referenced
this pull request
Sep 11, 2026
…agent-dev#32), atelet scheduling knobs
teemow
added a commit
to giantswarm/substrate
that referenced
this pull request
Sep 11, 2026
…agent-dev#32), atelet scheduling knobs
teemow
added a commit
to giantswarm/substrate
that referenced
this pull request
Sep 11, 2026
…ests; the #8 patches' commits as they are on giantswarm (#11) The second release of the line, v0.0.27-gs.2 (tag on ef30433 = gs.1 + the Postgres connection Secret cherry-picks of kagent-dev#32 and the atelet scheduling knobs, #8), published by run 34554981306 with every scan clean, gets its ledger row: index digests of the six images, the two chart digests, the dataplane it runs. The carried-patches table named the #8 commits by their pull-request branch SHAs (42c0c6b, 392841e, d9717d7), which the rebase merge rewrote; the commits on giantswarm are c1e4e32, f06f5ef and 084d916.
EItanya
force-pushed
the
main
branch
5 times, most recently
from
September 17, 2026 11:27
f60e0f3 to
74056c2
Compare
Allow ate-api-server to read an external PostgreSQL connection string from a Secret while keeping schema configuration in the existing ConfigMap. Add Helm unit coverage for bundled, literal, Secret-backed, and invalid setups.
iplay88keys
force-pushed
the
iplay88keys/postgres-connection-secret
branch
from
September 17, 2026 17:23
41097da to
38af2c9
Compare
iplay88keys
marked this pull request as draft
September 18, 2026 21:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR requires a substrate bump after this upstream PR merges: agent-substrate#1752
Summary
postgres.connectionStringSecretRefso the chart can read the Substrate runtime/DML connection from a Kubernetes Secret instead of placing credentials in a ConfigMap.postgres.ddlConnectionStringandpostgres.ddlConnectionStringSecretRefsettings for a separate schema-owner connection used by migrations and maintenance.ATE_API_POSTGRES_DDL_CONNECTION_STRINGand--postgres-ddl-connection-string=@env.postgres.schemain the existing ConfigMap and default enabled Secret references without a name to the release-scoped<release>-postgres-connectionSecret.This lets parent charts provide PostgreSQL credentials through normal Kubernetes Secret references without coupling Substrate to a specific parent chart.
Configuration
The existing single-connection configuration remains supported:
For separate runtime/DML and DDL roles, both connections can come from the same Secret under different keys:
When the DDL connection is omitted, ateapi uses the runtime connection for both purposes. With separate roles, the DDL role owns the schema and creates its objects; after migrations, ateapi grants the runtime role the table and sequence permissions it needs. This avoids requiring operators to update grants whenever a migration adds a table.