Fix SSL certificate docs and cover both mac architectures - #151
Open
turegjorup wants to merge 2 commits into
Open
turegjorup wants to merge 2 commits into
turegjorup wants to merge 2 commits into
Conversation
The certificate path read ./treafik/ssl/, and the openssl config path was the Intel Homebrew prefix, which does not exist on Apple Silicon. Derive it from openssl version -d so one command covers both. Note that the wildcard only covers one level, and that a double wildcard is not a way around it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects two wrong paths in the SSL section of the README and makes the
opensslcommand work on Apple Silicon.Changes
./treafik/ssl/docker.crt; it is./traefik/ssl/docker.crtopensslconfig path was hardcoded to/usr/local/etc/openssl/openssl.cnf, the Intel Homebrew prefix. It is now derived withopenssl version -d, which resolves on Intel and Apple Silicon alike*.*.local.itkdev.dkis not a way around itWhy
The documented command fails outright on an Apple Silicon mac, because the config file it points at is not there. Verified the corrected command produces a certificate with the right SAN, and checked both wildcard claims with
openssl verify -verify_hostname:*.local.itkdev.dkmatchesitksites.local.itkdev.dkbut notidp.itksites.local.itkdev.dk, and a double wildcard matches neither. TwoDNS:entries, one per level, do work.Markdownlint passes with the repo config.