Skip to content

refactor: remove duplication from escrow code - #352

Draft
zguesmi wants to merge 7 commits into
mainfrom
refactor/remove-duplicate-events
Draft

refactor: remove duplication from escrow code#352
zguesmi wants to merge 7 commits into
mainfrom
refactor/remove-duplicate-events

Conversation

@zguesmi

@zguesmi zguesmi commented Sep 1, 2026

Copy link
Copy Markdown
Member

After removing native token support the existing architecture is not justifiable anymore.
IexecEscrowTokenFacet now inherits from IexecEscrow abstract contract instead of duplicating.

Before:

flowchart LR
    subgraph abstract
        FacetBase
        IexecEscrow
        IexecPocoCommon
        SignatureVerifier
    end
    IexecEscrow --> FacetBase
    IexecPocoCommon --> FacetBase
    SignatureVerifier --> FacetBase
    IexecPoco1Facet --> IexecEscrow & IexecPocoCommon & SignatureVerifier & FacetBase
    IexecPoco2Facet --> IexecEscrow & SignatureVerifier & FacetBase
    IexecPocoBoostFacet --> IexecEscrow & IexecPocoCommon & SignatureVerifier & FacetBase
    IexecPocoAccessorsFacet --> IexecPocoCommon & SignatureVerifier & FacetBase
    IexecOrderManagementFacet --> SignatureVerifier & FacetBase
    IexecAccessorsABILegacyFacet --> FacetBase
    IexecCategoryManagerFacet --> FacetBase
    IexecConfigurationExtraFacet --> FacetBase
    IexecConfigurationFacet --> FacetBase
    IexecEscrowTokenFacet --> FacetBase
    IexecPocoBoostAccessorsFacet --> FacetBase
    IexecRelayFacet --> FacetBase
Loading

After:

flowchart LR
    subgraph abstract
        FacetBase
        IexecEscrow
        IexecPocoCommon
        SignatureVerifier
    end
    IexecEscrow --> FacetBase
    IexecPocoCommon --> FacetBase
    SignatureVerifier --> FacetBase
    IexecPoco1Facet --> IexecEscrow & IexecPocoCommon & SignatureVerifier
    IexecPoco2Facet --> IexecEscrow & SignatureVerifier
    IexecPocoBoostFacet --> IexecEscrow & IexecPocoCommon & SignatureVerifier
    IexecPocoAccessorsFacet --> IexecPocoCommon & SignatureVerifier
    IexecOrderManagementFacet --> SignatureVerifier
    IexecAccessorsABILegacyFacet --> FacetBase
    IexecCategoryManagerFacet --> FacetBase
    IexecConfigurationExtraFacet --> FacetBase
    IexecConfigurationFacet --> FacetBase
    IexecEscrowTokenFacet --> IexecEscrow
    IexecPocoBoostAccessorsFacet --> FacetBase
    IexecRelayFacet --> FacetBase
Loading

@zguesmi zguesmi self-assigned this Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.53%. Comparing base (7de2258) to head (bb5de40).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   99.53%   99.53%   -0.01%     
==========================================
  Files          31       31              
  Lines        1077     1069       -8     
  Branches      206      215       +9     
==========================================
- Hits         1072     1064       -8     
  Misses          5        5              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant