fix: Fail open on any error resolving the project ID in the ADK templates. - #7149
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: vertex-ai
copybara-service
Bot
force-pushed
the
copybara_981563579
branch
3 times, most recently
from
September 15, 2026 18:02
4b11506 to
047810a
Compare
…ates. `AdkApp.project_id()` converts a project number into a project ID with a Cloud Resource Manager `projects.get` call, but tolerated only `PermissionDenied` and `Unauthenticated`. Any other failure -- a gRPC `Unknown` when network interception terminates the stream, a `DeadlineExceeded` from a slow lookup -- escaped `set_up()` and stopped the agent from starting. The lookup is cosmetic, since every caller works with the project number, so it now falls back to the project number on any error and logs a warning, matching what `aiplatform.initializer` already does for the same call. PiperOrigin-RevId: 981933906
copybara-service
Bot
force-pushed
the
copybara_981563579
branch
from
September 15, 2026 18:34
047810a to
30bf665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Fail open on any error resolving the project ID in the ADK templates.
AdkApp.project_id()converts a project number into a project ID with a CloudResource Manager
projects.getcall, but tolerated onlyPermissionDeniedandUnauthenticated. Any other failure -- a gRPCUnknownwhen networkinterception terminates the stream, a
DeadlineExceededfrom a slow lookup --escaped
set_up()and stopped the agent from starting. The lookup is cosmetic,since every caller works with the project number, so it now falls back to the
project number on any error and logs a warning, matching what
aiplatform.initializeralready does for the same call.