feat(google/cloud/apptopology/v1): add google-cloud-apptopology - #18241
feat(google/cloud/apptopology/v1): add google-cloud-apptopology#18241noahdietz wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new google-cloud-apptopology Python client library, including its generated GAPIC clients, transports, types, configuration files, tests, and documentation. Feedback on the changes highlights an obsolete runtime compatibility check for google.protobuf in the generated __init__.py file, which should be removed via the generator or templates since the minimum dependency is already enforced in setup.py.
| _dependency_package = "google.protobuf" | ||
| _next_supported_version = "6.33.5" | ||
| _next_supported_version_tuple = (6, 33, 5) | ||
| _recommendation = " (we recommend 7.x)" | ||
| (_version_used, _version_used_string) = _get_version(_dependency_package) | ||
| if _version_used and _version_used < _next_supported_version_tuple: | ||
| warnings.warn( | ||
| f"Package {_package_label} depends on " | ||
| + f"{_dependency_package}, currently installed at version " | ||
| + f"{_version_used_string}. Future updates to " | ||
| + f"{_package_label} will require {_dependency_package} at " | ||
| + f"version {_next_supported_version} or higher{_recommendation}." | ||
| + " Please ensure " | ||
| + "that either (a) your Python environment doesn't pin the " | ||
| + f"version of {_dependency_package}, so that updates to " | ||
| + f"{_package_label} can require the higher version, or " | ||
| + "(b) you manually update your Python environment to use at " | ||
| + f"least version {_next_supported_version} of " | ||
| + f"{_dependency_package}.", | ||
| FutureWarning, | ||
| ) |
There was a problem hiding this comment.
The runtime compatibility check for 'google.protobuf' version '< 6.33.5' is obsolete because the package's minimum dependency configuration in 'setup.py' has already been updated to require 'protobuf >= 6.33.5'. This check should be removed. Since this is a generated file, please ensure this change is implemented in the generator or templates rather than as a manual modification to prevent it from being overwritten.
References
- Remove obsolete compatibility checks for older dependency versions (such as Protobuf v3) when the repository's minimum dependency configuration (e.g., setup.py) has been updated to require a newer version (such as Protobuf 6.x).
3a06aca to
d139669
Compare
|
Is there a reason this is in the individual release-please config instead of the bulk? |
It's a new library and needs to be explicitly registered on PyPi b4 releasing. Making it part of the bulk release will block the bulk release until whoever is responsible for registering this new package on PyPi has done so. If there are multiple new libraries to release (which there are right now) it is impossible* to registry all at once thus impossible to merge the bulk release PR containing all of them *well not impossible but it will fail. |
3 participants
Onboard google/cloud/apptopology/v1 to google-cloud-python using Librarian.
Internal tracking bug http://b/551671220