feat(generator): emit callable getter and convenience method for resumable upload RPCs - #14319
feat(generator): emit callable getter and convenience method for resumable upload RPCs#14319whowes wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for generating resumable upload RPC methods in the Java GAPIC generator. Key changes include adding Javadoc warnings and custom parameter documentation for resumable upload methods, generating a default method that accepts an InputStream payload and utilizes ResumableUploadCallable and ApiExceptions.callAndTranslateApiException, suppressing standard flattened method variants and sample code for these methods, and generating placeholder integration test methods instead of standard unit tests. A new test suite ResumableUploadServiceClientComposerTest has been added to verify these generation behaviors. There are no review comments to address, so I have no feedback to provide.
…mable upload RPCs - In AbstractServiceStubClassComposer: emit public ResumableUploadCallable<RequestT, ResponseT> [method]Callable() throwing UnsupportedOperationException - In AbstractServiceClientClassComposer: emit public ResumableUploadCallable<RequestT, ResponseT> [method]Callable() delegating to stub - In AbstractServiceClientClassComposer: emit synchronous convenience method [method](RequestT request, InputStream payload) calling ApiExceptions.callAndTranslateApiException - Suppress method variants (flattened methods) for resumable upload RPCs - In ServiceClientCommentComposer: emit Javadoc call context override warning on both callable method and synchronous convenience method - Add unit test ResumableUploadServiceClientComposerTest verifying generated stub and client methods
a07c67a to
e0d1fe6
Compare
|
|
1 participant
Work in progress, not ready for review