Skip to content

test(spanner): deflake CloseSpannerWithOpenResultSetTest - #14289

Merged
sakthivelmanii merged 1 commit into
mainfrom
deflake-close-spanner-watchdog-timeout
Sep 9, 2026
Merged

test(spanner): deflake CloseSpannerWithOpenResultSetTest#14289
sakthivelmanii merged 1 commit into
mainfrom
deflake-close-spanner-watchdog-timeout

Conversation

@sakthivelmanii

Copy link
Copy Markdown
Contributor

CloseSpannerWithOpenResultSetTest sets
com.google.cloud.spanner.watchdogTimeoutSeconds to 1 second in @BeforeClass.

During testStreamsAreCleanedUp, 16 threads concurrently execute 32 queries against a freshly created Spanner client. Under high CPU load in CI, thread contention during cold-start initialization can cause stream chunk delivery to exceed 1 second, intermittently triggering DEADLINE_EXCEEDED: stream wait timeout.

Increase the stream watchdog timeout from 1 second to 5 seconds to provide sufficient headroom under multi-threaded CI load while retaining fail-fast behavior if a mock stream hangs.

CloseSpannerWithOpenResultSetTest sets
com.google.cloud.spanner.watchdogTimeoutSeconds to 1 second in
@BeforeClass.

During testStreamsAreCleanedUp, 16 threads concurrently execute 32 queries
against a freshly created Spanner client. Under high CPU load in CI,
thread contention during cold-start initialization can cause stream chunk
delivery to exceed 1 second, intermittently triggering
DEADLINE_EXCEEDED: stream wait timeout.

Increase the stream watchdog timeout from 1 second to 5 seconds to provide
sufficient headroom under multi-threaded CI load while retaining fail-fast
behavior if a mock stream hangs.
@sakthivelmanii
sakthivelmanii requested review from a team as code owners September 8, 2026 05:37

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the watchdog timeout system property com.google.cloud.spanner.watchdogTimeoutSeconds from 1 to 5 seconds in the CloseSpannerWithOpenResultSetTest class. I have no feedback to provide.

@sakthivelmanii
sakthivelmanii merged commit 3582f6c into main Sep 9, 2026
204 checks passed
@sakthivelmanii
sakthivelmanii deleted the deflake-close-spanner-watchdog-timeout branch September 9, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants