Skip to content

How can we move .github/workflows/ci.yaml back to synthtool's template? #1720

Description

@suztomo

As synthtool's template does not call .kokoro/install_dependencies.sh , I had to exclude ci.yaml from synthtool's management: https://github.com/googleapis/google-api-java-client/pull/1699/files#diff-c881f5091bb23fef16e6e6da031e4268bbb11bb3404c1a2c7da8afa53c26f4ecL32.

What's missing in synthtool's template

install_dependencies is not called.

How about the following options?

  • build.sh to call install_dependencies.sh if it exists
  • GitHub actions (ci.yaml) to call install_dependencies.sh if it exists

Does install_dependencies.sh work in Windows?

Synthtool's template is missing to disable CRLF conversion.

    - name: git configuration to avoid automatic CRLF conversion
      run: |
        git config --global core.autocrlf false
        git config --global core.eol lf

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p4type: processA process-related concern. May include testing, release, or the like.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions