fix(cli): prevent SSE disconnect corruption - #6924
Open
gioboa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Problem:
Disconnecting a
/run_sseclient cancelled the active agent run. Long-runningtools stopped before completion and left incomplete events in the session.
Solution:
Run the agent lifecycle in a server-managed task and relay events to the SSE client through a bounded queue.
A disconnected client stops receiving events, while the agent run continues and persists its remaining events.
Active tasks are cancelled during server shutdown.
Testing Plan
Unit Tests:
Ran:
The regression test closes the SSE response after its first event and verifies
that the underlying agent run finishes without cancellation.
Manual End-to-End (E2E) Tests:
adk webwith a temporary agent containing a deterministic modeland a 20-second asynchronous tool.
/run_sse.Observed:
and final model response.
Checklist